- Launch of XLS-30D amendment introducing AMM on XRPL delayed due to critical bug, causing validators to withdraw support.
- RippleX proposes fix for AMM code bug, aiming to ensure stability and correct transaction execution.
The highly-anticipated XLS-30D amendment, which was set to revolutionize the XRP Ledger (XRPL) with the introduction of an Automated Market Maker (AMM), has hit a snag. Scheduled for launch on February 14, the amendment’s deployment has been indefinitely postponed. This development comes as a result of a critical bug discovered in the AMM code, leading to a significant number of validators revoking their support.
1/ In extended integration testing to ensure the AMM performs as intended over time, we identified an issue that could prevent multiple AMM txs from executing in the same ledger. We have proposed and are reviewing a fix: https://t.co/MPMKuI8dDK
— RippleX (@RippleXDev) February 1, 2024
Critical Bug Identified in AMM Code
The bug was unearthed by RippleX, the development arm of Ripple, during a period of extended testing. It presents a potential stumbling block for the execution of multiple AMM transactions within the same ledger. Specifically, the glitch impacts an edge case scenario where the trading fee is set below the all-important 0.01% threshold.
In such instances, a cluster of transactions on the AMM could cause some transactions to temporarily halt for one ledger cycle, leading to a delay of three to five seconds before execution.
This hiccup in transaction processing, while seemingly minor, has raised considerable concerns among the XRPL community. RippleX has been quick to propose a solution, which is currently under review.
The proposed fix aims to address the issue by ensuring the correct identification of default fields within AMM inner objects, thereby reinforcing stability across both the core ledger and AMM code.
Validator Response and Withdrawal
Despite the relative insignificance of the bug’s impact, the reaction from XRPL validators has been swift and decisive. The amendment had initially achieved the required validator consensus on February 1, with a set implementation date of February 14. However, the discovery of the bug has led to a notable shift in stance among validators, with many withdrawing their “yes” votes.
Vet, a prominent XRPL validator, has voiced concerns over the potential negative impact that launching a feature with a known bug could have on the XRPL’s reputation. Drawing parallels with the XLS-20D amendment, Vet highlighted the paramount importance of a flawless launch for such critical features, advocating for the bug to be fixed before the AMM’s implementation.
Echoing Vet’s sentiments, xSpectar, another key validator, underscored the critical nature of the feature and the imperative to address known issues before its activation.
After careful (re)consideration we’ve changed our vote on the AMM amendment to Nay
It’s a critical feature, there is a known issue, we need to fix first before activating.
Voting otherwise would be irresponsible and compromise our integrity and it would be a dangerous… https://t.co/K0WkCaKdGn
— xSPECTAR ™ (@xSPECTAR) February 7, 2024
The official xSpectar account went further, emphasizing that it is the responsibility of validators to avoid setting a dangerous precedent by allowing amendments with known flaws to pass.
Daniel, CTO at Eminence and operator of the Eminence validator, has taken a principled stand by withdrawing his support for the proposed AMM amendment.
Citing concerns over compromising the integrity of best practices, Daniel stressed the importance of prioritizing stability and functionality, even at the cost of delaying the feature. He proposed deprecating the current AMM in favor of introducing AMMv2, which would incorporate necessary fixes.
I have decided to withdraw my vote on the proposed AMM amendment. After careful consideration and discussion within our community, the proposed feature, as it stands, goes against the best practices we strive to uphold.
Specifically, my concern lies in releasing a feature with a…
— Daniel "No" Keller (@daniel_wwf) February 7, 2024
As a result of these developments, the consensus among validators has dipped to 71.43%, falling short of the required 80%. Consequently, the amendment will not pass as scheduled. Nonetheless, it’s worth noting that most validators, including industry heavyweights like Ripple, Bithomp, XRPScan, Alloy Networks, Bitrue, and 20 others, have maintained their support.
At the time of writing, the price of XRP has risen 2.29% in the last 24 hours, reaching a price of $0.5126. This represents an increase of 4.04% over the past 7 days.